-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix launching a browser results in closed file already closed error #648
Comments
I was able to reproduce this issue with the help of https://stackoverflow.com/questions/70422836/error-in-reading-the-byte-read-0-file-already-closed-in-go. I wasn't able to reproduce this just by stress testing the test unfortunately. It had to be done in a manual way:
Obviously this isn't a great way to replicate the issue. What it does show is that it's somewhat out of our control if the browser process die. Happy to discuss solutions, maybe we retry the launch? |
After a quick discussion, here are the next steps:
|
When the browser fails to load prior to xk6-browser connecting to it via CDP, then we need to make it clear what's happened. Partially Closes: #648
When the browser fails to load prior to xk6-browser connecting to it via CDP, then we need to make it clear what's happened. Partially Closes: #648
I believe the Github Action Runners provide enough computer power to run the tests: https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources. WDYT @inancgumus @ka3de? |
@ka3de has been hitting this issue frequently today e.g. https://github.com/grafana/xk6-browser/actions/runs/4025838004/jobs/6919871984. I'll try to investigate within the CI job (lots of logging). |
@grafana/k6-browser I've removed my assignment as I have yet to work on it. |
Brief summary
TestBrowserCrashErr
ends with the following error when trying to launch a browser:Although we only observe the error on CI for now. It can be problematic in some instances when users launch a browser too. We need to fix it before it happens again.
xk6-browser version
79b7f08
OS
Github CI
Chrome version
107.0.5304.110
Docker version and image (if applicable)
No response
Steps to reproduce the problem
Last detected in:
TestBrowserCrashErr
.https://github.com/grafana/xk6-browser/actions/runs/3438417446/jobs/5734442790
Expected behaviour
No error.
Actual behaviour
Error.
Related issues
#415, #363.
The text was updated successfully, but these errors were encountered: