Fix the check on examples/fillform.js #1022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
changed the title
ankur22
force-pushed
the
fix/example-fillform
branch
from
a46b212
to
f45856d
Compare
inancgumus
previously approved these changes
Sep 1, 2023
ankur22
added a commit
that referenced
this pull request
Sep 1, 2023
This will help distinguish between page and the local variable in the check. Resolves: #1022 (comment) Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
ankur22
force-pushed
the
fix/example-fillform
branch
from
f45856d
to
84ca43c
Compare
inancgumus
previously approved these changes
Sep 1, 2023
ankur22
added a commit
that referenced
this pull request
Sep 1, 2023
This will help distinguish between page and the local variable in the check. Resolves: #1022 (comment) Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
ankur22
force-pushed
the
fix/example-fillform
branch
from
84ca43c
to
27ded62
Compare
ka3de
approved these changes
Sep 1, 2023
inancgumus
approved these changes
Sep 1, 2023
The check on the fillform example test worked but is not quite correct. Check actually expects a function that returns a boolean, as is is documented.
This will help distinguish between page and the local variable in the check. Resolves: #1022 (comment) Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
ankur22
force-pushed
the
fix/example-fillform
branch
from
27ded62
to
0b5d155
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change will fix the
checkin the example/fillform.js test.Why?
checkactually expects a function that returns aboolean, as is documented. Although thecheckaccepts the object as we've been using it, it's not correct. When users work with this example and the type definitions for k6, they will see a red line under the'header'incheck, which will cause confusion and annoyance as to why our own examples have errors.Checklist