Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine PR and Issue templates #1024

Merged
merged 6 commits into from Sep 1, 2023
Merged

Refine PR and Issue templates #1024

merged 6 commits into from Sep 1, 2023

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Sep 1, 2023 •
edited

What?

  1. Refines the PR template.
  2. Add an issue template for the internal team.
  3. Updates the community forum link.
  4. Adds the migration guide link to the new issue page.

I can't preview these templates, so IDK how they will look when rendered. Update: I found a suboptimal way. Go to the issue template file on the Github UI.

Why?

To provide better workflow both for internal and external contributors.

@inancgumus inancgumus force-pushed the update/pr-issue-templates branch 2 times, most recently from 7b73e6e to 1030a9f Compare September 1, 2023 09:41
ka3de
ka3de reviewed Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this @inancgumus ! 🙌
Just a few considerations.

.github/ISSUE_TEMPLATE/config.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/config.yml Show resolved Hide resolved
.github/ISSUE_TEMPLATE/team_issues.yaml Outdated Show resolved Hide resolved
.github/ISSUE_TEMPLATE/team_issues.yaml Show resolved Hide resolved
ka3de
ka3de previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

ankur22
ankur22 previously approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tackling this. Hopefully we have a more consistent way of creating issues now 🙂 LGTM 👍

.github/ISSUE_TEMPLATE/team_issues.yaml Outdated Show resolved Hide resolved
@inancgumus inancgumus dismissed stale reviews from ankur22 and ka3de via 4ffeaf1 September 1, 2023 15:36
@inancgumus @ankur22 @ka3de
Improve issue template suggestion wording
bca88d4 
Co-authored-by: Ankur Agarwal <ankur.agarwal@grafana.com>
Co-authored-by: ka3de <danijs12@hotmail.com>
ankur22
ankur22 approved these changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@inancgumus inancgumus merged commit 5ef2768 into main Sep 1, 2023
13 checks passed
@inancgumus inancgumus deleted the update/pr-issue-templates branch September 1, 2023 15:57
@inancgumus inancgumus self-assigned this Sep 7, 2023
@inancgumus inancgumus added the dx developer experience label Sep 7, 2023
@inancgumus inancgumus added productivity Issues and PRs that improve our productivity and removed dx developer experience labels Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankur22 ankur22 ankur22 approved these changes

@ka3de ka3de Awaiting requested review from ka3de

Assignees

@inancgumus inancgumus

Labels
productivity Issues and PRs that improve our productivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@inancgumus @ankur22 @ka3de