Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cookies: Fix Goja conversions #1039

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Cookies: Fix Goja conversions #1039

merged 3 commits into from
Sep 19, 2023

Commits on Sep 19, 2023

  1. Fix cookie conversions to/from Goja 

    Goja cannot convert a JavaScript value provided by the user into an
api.Cookie type. While converting, Goja misses the api.CookieSameSite
and httpOnly. The underlying reason is the missing `js` struct tag.
    @inancgumus
    inancgumus committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    a50f4d2 View commit details
    Browse the repository at this point in the history

  2. Improve cookie JS example for robust E2E testing 

    Checks the goja-incompatible fields to ensure we're setting them while
adding and retriving cookies.  We do this only for the cookie to not to
conflate the example.
    @inancgumus
    inancgumus committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    8f25933 View commit details
    Browse the repository at this point in the history

  3. Add js tags to all cookie fields for consistency 

    Resolves: https://github.com/grafana/xk6-browser/pull/1039/files/a50f4d2cd94538777603ecff98cd94eb89bc1433#r1330162707
    @inancgumus
    inancgumus committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    ac67ec1 View commit details
    Browse the repository at this point in the history