Fix browserContext.clearPermissions #1077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
previously approved these changes
Oct 20, 2023
ankur22
force-pushed
the
refactor/grantPermissions
branch
2 times, most recently
from
f7f3714
to
50992a9
Compare
ankur22
force-pushed
the
fix/443-clearPermissions
branch
2 times, most recently
from
7768d01
to
3faf6ed
Compare
ankur22
dismissed stale reviews from ka3de and inancgumus
The base branch was changed.
Add the missing cdp executor which will be used to perform the cdp request. Related: #1040
Add a clearPermissions command which will ensure that we don't regress the fix for clearPermissions.
This change adds code to assert on whether the permissions have been granted before and after certain actions. Co-authored-by: İnanç Gümüş <inanc.gumus@grafana.com>
ankur22
force-pushed
the
fix/443-clearPermissions
branch
from
468d2e0
to
8c31905
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This fixes the error when
browserContext.clearPermissionsis called.Why?
It was erroring due to the CDP request not being setup correctly.
Checklist
Related PR(s)/Issue(s)
Closes: #443