Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use os & io instead of ioutil #1090

Merged
merged 2 commits into from Nov 2, 2023
Merged

Update to use os & io instead of ioutil #1090

merged 2 commits into from Nov 2, 2023

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Nov 1, 2023 •
edited

What?

Replacing ioutil with os and io where needed.

Why?

ioutil is deprecated, and instead we should work with os and io.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

inancgumus
inancgumus approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

ka3de
ka3de approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ankur22
Update to use os instead ioutil
b69362a 
ioutil is deprecated, and instead we should work with os when writing
files to the disk.
@ankur22
Update to use io instead of ioutil
133d937 
This replaces the usage of ioutil.Discard with io.Discard since ioutil
has been deprecated.
@ankur22 ankur22 merged commit bebb4ae into main Nov 2, 2023
17 checks passed
@ankur22 ankur22 deleted the fix/writefile branch November 2, 2023 10:14
@ankur22 ankur22 changed the title Update to use os & io instead ioutil Update to use os & io instead of ioutil Nov 2, 2023
@ankur22 ankur22 mentioned this pull request Nov 2, 2023
Merged
5 tasks
@Porkepix Porkepix mentioned this pull request Dec 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inancgumus inancgumus inancgumus approved these changes

@ka3de ka3de ka3de approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ankur22 @inancgumus @ka3de