Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the timeout option from isVisible and isHidden #1111

Merged
merged 9 commits into from
Nov 28, 2023
Merged

Remove the timeout option from isVisible and isHidden #1111

merged 9 commits into from
Nov 28, 2023

Commits on Nov 23, 2023

  1. Remove timeout parameter for isVisible 

    This removes the need to pass in a 0 value for the timeout from frame
and elementHandle.

The reason for removing the timeout is that isVisible doesn't wait on
an element, so there is no need for a timeout.
    @ankur22
    ankur22 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    8ca6ebe View commit details
    Browse the repository at this point in the history

  2. Remove timeout parameter for isHidden 

    This removes the need to pass in a 0 value for the timeout from frame
and elementHandle.

The reason for removing the timeout is that isHidden doesn't wait on
an element, so there is no need for a timeout.
    @ankur22
    ankur22 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    293b879 View commit details
    Browse the repository at this point in the history

  3. Remove the timeout from the isVisible option 

    The timeout is no longer used since isVisible now returns straight
away without waiting for an element to match if one doesn't already
exist.
    @ankur22
    ankur22 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    5884154 View commit details
    Browse the repository at this point in the history

  4. Remove the options on locator.isVisible 

    It did accepts options which were strict and timeout. Strict is enabled
and cannot be changed when working with the locator API. Timeout is no
longer useful when working with isVisible.
    @ankur22
    ankur22 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    0bb82a7 View commit details
    Browse the repository at this point in the history

  5. Refactor locator.isVisible to return an error

    @ankur22
    ankur22 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    c38f9b8 View commit details
    Browse the repository at this point in the history

  6. Remove the timeout from the isHidden option 

    The timeout is no longer used since isHidden now returns straight
away without waiting for an element to match if one doesn't already
exist.
    @ankur22
    ankur22 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    300e19b View commit details
    Browse the repository at this point in the history

  7. Remove the options on locator.isHidden 

    It did accepts options which were strict and timeout. Strict is enabled
and cannot be changed when working with the locator API. Timeout is no
longer useful when working with isHidden.
    @ankur22
    ankur22 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    5928ccd View commit details
    Browse the repository at this point in the history

  8. Add common parsing of strict option

    @ankur22
    ankur22 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    7e4d5ee View commit details
    Browse the repository at this point in the history

  9. Refactor option parsing to use parseStrict

    @ankur22
    ankur22 committed Nov 23, 2023
    Configuration menu
    Copy the full SHA
    08d3dd8 View commit details
    Browse the repository at this point in the history