Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor page.click option parsing #1175

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Refactor page.click option parsing #1175

merged 2 commits into from
Jan 23, 2024

Commits on Jan 23, 2024

  1. Add page.Timeout for internal parse use 

    This timeout method is to be called from the mapping layer when parsing
options.
    @ankur22
    ankur22 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    73563ba View commit details
    Browse the repository at this point in the history

  2. Refactor parse our of page.click 

    This helps avoid using the goja runtime when it comes to parsing the
options. The options parsing has been moved to the mapping layer and so
has been moved back on to the main goja thread, which will mitigate the
possibility of a panic which could occur when multiple goroutines try
to work with the goja runtime (which is not thread safe).

There is another issue to tackle more of the goja refactoring in
    @ankur22
    ankur22 committed Jan 23, 2024
    Configuration menu
    Copy the full SHA
    d57dba3 View commit details
    Browse the repository at this point in the history