Fix data race with logging #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankur22
force-pushed
the
fix/1066_data_race
branch
from
2ff68f5
to
31880f3
Compare
The log formatter causes two issues: 1. When we use the loki output, it can cause a race condition since the loki hook works with the entry (the log message and metadata) asynchronously, which means that while the hook reads the entry, the formatter could be amending the same entry. The entry is not thread safe. 2. The formatter is only used in one place, which is when writing the output from console.log that is used in the website under test. This change could safely be moved to where it's used, which also makes it clear how the console message is formatted before being logged.
The serializer doesn't do anything new now that the formatter has been removed, so use the logger.
The serializer isn't needed since all it does is create a clone of the existing logger.
ankur22
force-pushed
the
fix/1066_data_race
branch
from
31880f3
to
befcc00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Remove the use of the logrus formatter.
Why?
Full details can be found here: #1066 (comment)
Checklist
Related PR(s)/Issue(s)
Updates: #1066