Refactor Sobek out of browserContext.addinitscript #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This argument isn't being used so it's better to remove it for now and add it back in when requested for.
This was to avoid linter issues.
ankur22
force-pushed
the
refactor/bc-addinitscript
branch
from
1201b93
to
d387982
Compare
ankur22
changed the title
inancgumus
reviewed
Mar 4, 2024
inancgumus
approved these changes
Mar 4, 2024
inancgumus
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Refactor browserContext.addinitscript to move the goja code into the mapping layer.
Why?
This will help isolate goja specific code in the mapping layer.
Checklist
Related PR(s)/Issue(s)
#1064
https://github.com/grafana/k6-cloud/issues/2066