Add test run id to RootModule #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us keep track of the current test run id and allow components in the browser module to work with it.
This will read and record the value of K6_CLOUD_PUSH_REF_ID when it is available and not an empty string. The test run id will be available to any component that requires it.
inancgumus
approved these changes
Mar 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This adds the test run ID to the
RootModuleallowing any browser component to work with the test run ID.Why?
This is a requirement to allow better integration with external tools (such as faro)to be used to label sessions with a test run ID. The test run id will eventually be populated in the
window.k6object which is injected into each and everybrowserContextandpage.The change localises the retrieval of the test run id in one place instead of having every component need to do a lookup for an env var.
Checklist
Related PR(s)/Issue(s)
Updates: https://github.com/grafana/k6-cloud/issues/2066