Move websocket test server to its own package #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imiric
reviewed
Dec 22, 2021
inancgumus
added a commit
that referenced
this pull request
Dec 23, 2021
inancgumus
added a commit
that referenced
this pull request
Dec 23, 2021
inancgumus
force-pushed
the
refactor/move-ws-test-server
branch
from
ee535e3
to
44c697b
Compare
inancgumus
force-pushed
the
refactor/move-ws-test-server
branch
from
44c697b
to
1908389
Compare
imiric
reviewed
Dec 23, 2021
Co-authored-by: Ivan Mirić <ivan.miric@grafana.com>
imiric
approved these changes
Dec 23, 2021
|
Thank you, @imiric, for reviewing this and helping me see some edge cases I missed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is experimentation that I created for getting feedback.
I plan to add the
BrowserType.Connectfeature (#17) and put the related tests in thetestspkg.The first test will create a
BrowserTypeand then connect it to a WebSocket test server. To do that, I need a test WebSocket server, and thanks to Robin, there is actually one here, in thecommonpkg.There are also two tests in the
common/pkg that use the server. Since I will use the server from thetestspkg, there will be circular import errors.So I moved the server into
tests/ws. This solves the issues I explained above. I want to hear your input about this before continuing.