Fix unmap internal methods #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
added
bug
69 tasks
ka3de
approved these changes
Feb 20, 2023
inancgumus
force-pushed
the
refactor/mapping-toFirstLetterLower
branch
from
eab18d3
to
0ae492d
Compare
We shouldn't expose some of the methods as they are internal to the extension, have no meaning for the users, and Playwright doesn't support them. The refactoring to the test should be needed to be done with these together to not to break the tests.
inancgumus
force-pushed
the
fix/unmap-internal-methods
branch
from
c44f0a3
to
e4eb632
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't expose some of the methods as they are internal to the extension, have no meaning for the users, and Playwright doesn't support them.
Refactoring to the tests should be done with the fix together so as not to break the tests. Some parts could be in another commit, but the commit itself is short enough anyway.
Updates: #784