Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ErrInternal to ErrFatal and use abort #810

Merged
merged 7 commits into from
Mar 6, 2023
Merged

Rename ErrInternal to ErrFatal and use abort #810

merged 7 commits into from
Mar 6, 2023

Commits on Mar 6, 2023

  1. Rename ErrInternal to ErrFatal 

    Fatal better describes the error, and it will help distinguish from
other internal errors (which could be seen as temporary). Fatal is a
permanent error, which should end the whole test run not just the
current iteration.
    @ankur22
    ankur22 committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    68ce29f View commit details
    Browse the repository at this point in the history

  2. Refactor k6ext.Panic so we have shared code 

    The shared code will be used for the abort method.
    @ankur22
    ankur22 committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    1c140c9 View commit details
    Browse the repository at this point in the history

  3. Refactor k6ext.Panic so it passes fail func 

    Panic needs to differentiate what happens when Panic is called,
vs what will happen when abort is implemented. The rest of the
sharedPanic code is needed by both.
    @ankur22
    ankur22 committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    95a701a View commit details
    Browse the repository at this point in the history

  4. Add the abort func to stop the whole test run

    @ankur22
    ankur22 committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    5d0a2f0 View commit details
    Browse the repository at this point in the history

  5. Refactor cookies to work with ErrFatal 

    This is to show that the whole test run will also stop when we try
to use an unimplemented unpromisified API.
    @ankur22
    ankur22 committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    597e0e4 View commit details
    Browse the repository at this point in the history

  6. fixup! Add the abort func to stop the whole test run

    @ankur22
    ankur22 committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    b4828bf View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from code review 

    Cleanup `failFunc` to make it easier to read.

Co-authored-by: ka3de <daniel.jimenez@grafana.com>
    @ankur22 @ka3de
    ankur22 and ka3de committed Mar 6, 2023
    Configuration menu
    Copy the full SHA
    2fc49fd View commit details
    Browse the repository at this point in the history