Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix killing a browser process on panic if one of them is missing #832

Merged
merged 1 commit into from
Mar 17, 2023
Merged

Fix killing a browser process on panic if one of them is missing #832

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions k6ext/panic.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,8 +66,8 @@ func sharedPanic(ctx context.Context, failFunc func(rt *goja.Runtime, a ...any),
for _, pid := range pidder.Pids() {
p, err := os.FindProcess(pid)
if err != nil {
// optimistically return and don't kill the process
return
// optimistically skip and don't kill the process
continue
}
// no need to check the error for whether we could kill it as
// we're already dying.
Expand Down