Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the build github action #843

Merged
merged 2 commits into from Apr 4, 2023
Merged

Remove the build github action #843

merged 2 commits into from Apr 4, 2023

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Apr 3, 2023

xk6-browser is now an experiment module within k6. This means that we no longer need to build a dedicated version of xk6-browser binary and anyone wishing to download a pre-built binary should head over to the release section of the k6 repo.

@ankur22 ankur22 added the ci label Apr 3, 2023
@ankur22 ankur22 added this to the v0.9.0 milestone Apr 3, 2023
@ankur22 ankur22 self-assigned this Apr 3, 2023
@ka3de
Copy link
Collaborator

ka3de commented Apr 3, 2023

I think we can also remove the build-release-sh file as it was only referenced from the build GH action.

Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ankur22 ankur22 requested a review from inancgumus April 3, 2023 11:47
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but why does it fail? :)

@ankur22
Copy link
Collaborator Author

ankur22 commented Apr 3, 2023

LGTM but why does it fail? :)

The fix for the build is in #842.

xk6-browser is now an experiment module within k6. This means that we
no longer need to build a dedicated version of xk6-browser binary and
anyone wishing to download a pre-built binary should head over to the
release section of the k6 repo.
This is no longer needed since we're not going to be building a release
binary in github actions.
@ankur22 ankur22 merged commit 07cd48b into main Apr 4, 2023
12 checks passed
@ankur22 ankur22 deleted the ci/remove-build branch April 4, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants