Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove browser first contentful paint #847

Merged
merged 1 commit into from Apr 5, 2023

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Apr 4, 2023

This is a regression. We had removed this in #836, but it was accidentally added back in #838.

As mentioned in #831 (comment), we should work with the webvital_first_contentful_paint instead of browser_first_contentful_paint.

Linked to #831

This is a regression. We had removed this in
#836, but it was
accidentally added back in
#838.
@ankur22 ankur22 requested review from inancgumus and ka3de April 4, 2023 16:42
@ankur22 ankur22 self-assigned this Apr 4, 2023
@ankur22 ankur22 added this to the v0.9.0 milestone Apr 4, 2023
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add the bug label.

@ankur22 ankur22 added the bug Something isn't working label Apr 5, 2023
@ankur22 ankur22 merged commit c7b2283 into main Apr 5, 2023
12 checks passed
@ankur22 ankur22 deleted the remove/first-contentful-paint-metric branch April 5, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants