Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable timeout on browser process execution #866

Merged
merged 2 commits into from
May 9, 2023
Merged

Disable timeout on browser process execution #866

merged 2 commits into from
May 9, 2023

Commits on May 2, 2023

  1. Disable timeout on browser process launch 

    This commit modifies the browser launching process to not pass a context
with timeout to the actual browser process cmd handle. Currently this
was done using as timeout the value set for the browser.timeout option,
which should serve a different purpose.
    @ka3de
    ka3de committed May 2, 2023
    Configuration menu
    Copy the full SHA
    a42d17e View commit details
    Browse the repository at this point in the history

  2. Disable timeout on browser process connection 

    This commit modifies the browser connecting process to not pass a
context with timeout to the browser process implementation so its
closing handler is not triggered after the set timeout. Currently this
was done using as timeout the value set for the browser.timeout option,
which should serve a different purpose.
    @ka3de
    ka3de committed May 2, 2023
    Configuration menu
    Copy the full SHA
    1fa9bfb View commit details
    Browse the repository at this point in the history