Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WaitForNavigation with Click in Test #959

Merged
merged 1 commit into from
Jun 29, 2023
Merged

Add WaitForNavigation with Click in Test #959

merged 1 commit into from
Jun 29, 2023

Conversation

ankur22
Copy link
Collaborator

@ankur22 ankur22 commented Jun 28, 2023

Description of changes

This test was flaky due to the state changing during the navigation on click. Working with WaitForNavigation should resolve this.

Checklist

@ankur22 ankur22 requested a review from ka3de June 28, 2023 09:08
@ankur22 ankur22 changed the title Add WaitForNavigation with Click Add WaitForNavigation with Click in Test Jun 28, 2023
ka3de
ka3de approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@ka3de ka3de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙌

@ankur22 ankur22 merged commit 3015c48 into main Jun 29, 2023
13 checks passed
@ankur22 ankur22 deleted the fix/iframe-integartion-test branch June 29, 2023 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ka3de ka3de ka3de approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ankur22 @ka3de