Template labels #12
Merged
Template labels #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goos: linux goarch: amd64 pkg: github.com/grafana/xk6-client-prometheus-remote cpu: AMD Ryzen 5 3500U with Radeon Vega Mobile Gfx BenchmarkEvaluateTemplatesSimple-8 5036028 265.0 ns/op 32 B/op 2 allocs/op BenchmarkEvaluateTemplatesSimple-8 4212535 265.7 ns/op 32 B/op 2 allocs/op BenchmarkEvaluateTemplatesSimple-8 4397311 289.6 ns/op 32 B/op 2 allocs/op BenchmarkEvaluateTemplatesSimple-8 4099876 255.0 ns/op 32 B/op 2 allocs/op BenchmarkEvaluateTemplatesSimple-8 4200105 265.6 ns/op 32 B/op 2 allocs/op BenchmarkEvaluateTemplatesComplex-8 3664898 282.3 ns/op 28 B/op 2 allocs/op BenchmarkEvaluateTemplatesComplex-8 4777549 299.3 ns/op 28 B/op 2 allocs/op BenchmarkEvaluateTemplatesComplex-8 4231748 290.1 ns/op 28 B/op 2 allocs/op BenchmarkEvaluateTemplatesComplex-8 4330029 245.6 ns/op 28 B/op 2 allocs/op BenchmarkEvaluateTemplatesComplex-8 4678125 290.5 ns/op 28 B/op 2 allocs/op
This has less than the expected improvement but still something name old time/op new time/op delta EvaluateTemplatesSimple-8 268ns ± 8% 211ns ± 7% -21.17% (p=0.008 n=5+5) EvaluateTemplatesComplex-8 282ns ±13% 164ns ± 6% -41.79% (p=0.008 n=5+5) name old alloc/op new alloc/op delta EvaluateTemplatesSimple-8 32.0B ± 0% 32.0B ± 0% ~ (all equal) EvaluateTemplatesComplex-8 28.0B ± 0% 28.0B ± 0% ~ (all equal) name old allocs/op new allocs/op delta EvaluateTemplatesSimple-8 2.00 ± 0% 2.00 ± 0% ~ (all equal) EvaluateTemplatesComplex-8 2.00 ± 0% 2.00 ± 0% ~ (all equal)
Sort labels when generating them from templates
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Signed-off-by: Mauro Stettler <mauro.stettler@gmail.com>
Fixes around k6 v0.36.0 API changes
sure, i'm not expecting any complicated merge conflicts, so i don't think the order matters much |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to generate samples based on a template inside the extension, instead of generating them in the js and then passing them to the extension. The main benefit is performance.
Currently this is still missing documentation, that's why I opened it as draft only