Reuse everything #15
Closed
Reuse everything #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with streaming promql protobuf marshalling which cuts down on the number of allocations significantly. name time/op StoreFromPrecompiledTemplates-8 114ms ± 4% StoreFromTemplates-8 199ms ± 4% name alloc/op StoreFromPrecompiledTemplates-8 59.9MB ± 0% StoreFromTemplates-8 149MB ± 0% name allocs/op StoreFromPrecompiledTemplates-8 26.4 ± 6% StoreFromTemplates-8 589k ± 0%
mstoykov
force-pushed
the
reuseEverything
branch
from
d795024
to
ff9f6e1
Compare
name old time/op new time/op delta StoreFromPrecompiledTemplates-8 114ms ± 4% 113ms ± 9% ~ (p=0.489 n=9+9) StoreFromTemplates-8 199ms ± 4% 172ms ± 8% -13.89% (p=0.000 n=9+10) name old alloc/op new alloc/op delta StoreFromPrecompiledTemplates-8 59.9MB ± 0% 59.9MB ± 0% ~ (p=1.000 n=10+10) StoreFromTemplates-8 149MB ± 0% 145MB ± 0% -2.21% (p=0.000 n=8+10) name old allocs/op new allocs/op delta StoreFromPrecompiledTemplates-8 26.4 ± 6% 26.0 ± 0% ~ (p=0.173 n=10+9) StoreFromTemplates-8 589k ± 0% 311k ± 0% -47.21% (p=0.000 n=8+8)
name old time/op new time/op delta StoreFromPrecompiledTemplates-8 111ms ± 8% 111ms ±12% ~ (p=0.912 n=10+10) StoreFromTemplates-8 178ms ± 6% 116ms ±18% -34.61% (p=0.000 n=10+10) name old alloc/op new alloc/op delta StoreFromPrecompiledTemplates-8 59.9MB ± 0% 59.9MB ± 0% ~ (p=0.120 n=8+9) StoreFromTemplates-8 145MB ± 0% 60MB ± 0% -58.80% (p=0.000 n=10+10) name old allocs/op new allocs/op delta StoreFromPrecompiledTemplates-8 25.8 ± 5% 26.0 ± 0% ~ (p=0.353 n=10+7) StoreFromTemplates-8 311k ± 0% 0k ± 0% -99.95% (p=0.000 n=10+10) This still has 150 vs 26 allocations when the template is precompiled
Merged
|
closing in favor of #17 which rewrites the history and has some additional tests and cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.