Support custom headers in Config #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
philipgough
force-pushed
the
support-headers
branch
from
650247b
to
e4a8907
Compare
|
@mstoykov - what do you think about this change? Could we merge it? |
replay
reviewed
Nov 9, 2022
replay
approved these changes
Nov 9, 2022
Signed-off-by: Philip Gough <philip.p.gough@gmail.com>
philipgough
force-pushed
the
support-headers
branch
from
e4a8907
to
fed60f8
Compare
The use case here is to support other backends or proxies that use/require custom headers such as Thanos receive. |
|
@mstoykov I think we are good here then? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might be useful to be able to specify custom headers on top of the fields already exposed in the config.