Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Host header in http req #26

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Fix Host header in http req #26

merged 1 commit into from
Jan 13, 2023

Conversation

syepes
Copy link
Contributor

@syepes syepes commented Dec 19, 2022

The HTTP Host field can not be modified with the standard headers, this make it work

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2022

CLA assistant check
All committers have signed the CLA.

@syepes
Copy link
Contributor Author

syepes commented Jan 4, 2023

Any news on this merge? I would like to use the official images :-)

@mstoykov
Copy link
Contributor

Hi, sorry @syepes - I don't think anyone specifically looks at this repo at this point :(

After looking at the docs, as I don't really remember the precedence of Host the field, the header and the URL:

// For client requests, Host optionally overrides the Host
// header to send. If empty, the Request.Write method uses
// the value of URL.Host. Host may contain an international
// domain name.

It seems like this is truly needed to overwrite the host in case the header needs to be different from the one that is in the url, so 👍

@mstoykov mstoykov merged commit 2794598 into grafana:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants