adds the ability to write the generated series into a file #8
Conversation
| for _, envVar := range os.Environ() { | ||
| if len(envVar) > len(debugVar)+1 && envVar[:len(debugVar)+1] == debugVar+"=" { | ||
| debugFile := envVar[len(debugVar)+1:] | ||
| debugWriter = &LockedWriter{file: debugFile} |
There was a problem hiding this comment.
None of the requested changes are blocking this IMO.
On the other hand I don't think this change is all that interesting/useful for normal usage of the extension, so I would probably want it removed when we make this more ... presentable. But even if we don't I kind of would prefer if most of this (especially with some of the proposed changes) be moved in a separate file and interfere as little as possible with the rest of the extension.
Again though we can do that later :)
| f, err := os.OpenFile(lw.file, os.O_APPEND|os.O_WRONLY|os.O_CREATE, 0600) | ||
| if err != nil { | ||
| return 0, err | ||
| } |
There was a problem hiding this comment.
I do feel like it will be better if we open it once on initializaiton
There was a problem hiding this comment.
I guess that makes it harder to figure out when to close it, but I doubt that is a problem, I am pretty sure that os.File doesn't have any buffering by default so everything will be in kernel buffers either way so 🤷
| if debugBuilder != nil { | ||
| debugBuilder.WriteString(fmt.Sprintf( | ||
| "series: %s value: %f timestamp: %d\n", | ||
| labelsToString(series[seriesID-minSeriesID].Labels), | ||
| series[seriesID-minSeriesID].Samples[0].Value, | ||
| series[seriesID-minSeriesID].Samples[0].Timestamp, | ||
| )) | ||
| } | ||
| } | ||
|
|
||
| if debugWriter != nil && debugBuilder != nil { | ||
| _, err := debugWriter.Write(debugBuilder.String()) | ||
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| } |
There was a problem hiding this comment.
maybe all of this can just be done over the returned []prompb.TimeSeries possibly even not in this function but some of the others where it's also send maybe in store itself through a single dumpTimeSeriesInDebugFile call
|
@replay Sorry for the delay, are you still looking for a review on this? |
Thanks for asking, i think that's not necessary anymore :) I'll close the PR |
This is useful to validate that our test definition is generating the series we think it should be generating.
When running like this:
It will write the generated series into
/tmp/debug1.