Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic build system using make and Docker #4

Merged
merged 4 commits into from
Oct 21, 2022
Merged

Basic build system using make and Docker #4

merged 4 commits into from
Oct 21, 2022

Conversation

stoewer
Copy link
Collaborator

@stoewer stoewer commented Oct 21, 2022

Add a build system using make and Docker:

  • The Makefile simplifies the commands required to build the project.
  • The Makefile can lint the code using golangci-lint.
  • Building a xk6-client-tracing Docker container allows the use of docker-compose which makes it easier to run the provided example.

@stoewer stoewer requested a review from mapno October 21, 2022 02:34
@CLAassistant
Copy link

CLAassistant commented Oct 21, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

mapno
mapno approved these changes Oct 21, 2022
View reviewed changes
Copy link
Member

@mapno mapno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@mapno mapno merged commit f5d3c6a into grafana:main Oct 21, 2022
@stoewer stoewer deleted the build-system-and-docker branch October 25, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapno mapno mapno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stoewer @CLAassistant @mapno