Refactoring and template trace generator #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move trace genration from the function GenerateResource into the the ParameterizedGenerator
mapno
reviewed
Nov 4, 2022
stoewer
added a commit
that referenced
this pull request
Nov 7, 2022
Refactored the code and introduce the concept of different trace generators. The existing functionality to generate traces is now provided by tracing.ParameterizedGenerator Implement a new generator that creates traces and spans from a configurable template with the goal to generate more realistiacally looking traces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
The purpose of this change is create more realistiacally looking traces with
xk6-client-tracing.tracing.ParameterizedGenerator.Which issue(s) this PR fixes:
May help to solve grafana/tempo#902 because
xk6-client-tracingcould be used as a replacement for thesynthetic-load-generator