Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove service proxy test helper #285

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Remove service proxy test helper #285

merged 1 commit into from
Aug 9, 2023

Conversation

pablochacin
Copy link
Collaborator

Description

The service proxy test helper was introduced to facilitate access to services in e2e tests without having to expose them in the cluster. Since #160 e2e tests use ingresses for accessing services, making the service proxy redundant.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant e2e test locally (make e2e-xxx for agent, disruptors, kubernetes or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin merged commit d2f9caa into main Aug 9, 2023
7 checks passed
@pablochacin pablochacin deleted the remove-service-proxy branch August 9, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant