Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply fault injection validations uniformly #316

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Apply fault injection validations uniformly #316

merged 1 commit into from
Aug 25, 2023

Conversation

pablochacin
Copy link
Collaborator

Description

Apply relevant validations in all fault injection methods in Pod and Service disruptors across protocols (HTTP, GRPC)

Fixes #299

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant e2e test locally (make e2e-xxx for agent, disruptors, kubernetes or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

@pablochacin
unify fault injection validations
da4c87c 
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@pablochacin pablochacin changed the title unify fault injection validations Unify fault injection validations Aug 24, 2023
@pablochacin pablochacin changed the title Unify fault injection validations Apply fault injection validations uniformly Aug 24, 2023
roobre
roobre approved these changes Aug 25, 2023
View reviewed changes
Copy link
Collaborator

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for catching this!

@pablochacin pablochacin merged commit b50ce14 into main Aug 25, 2023
7 checks passed
@pablochacin pablochacin deleted the unify-disruptor-validations branch August 25, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roobre roobre roobre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply fault injection validations uniformly across protocols and disruptors
2 participants
@pablochacin @roobre