Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use default options in all e2e tests #317

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Conversation

pablochacin
Copy link
Collaborator

Description

In order to facilitate reusing the test cluster use default options in all e2e tests.

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant e2e test locally (make e2e-xxx for agent, disruptors, kubernetes or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Copy link
Collaborator

@roobre roobre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I understand how the tooling is intended to be used after this change.

If I'm reading this correctly:

  • Different E2E tests now use the same cluster name and run in parallel
  • E2E tests still have reuse: false and cleanup: true by default

Wouldn't this cause issues if tests are (accidentally or not) started without E2E_REUSE=1?
If this is the case, shouldn't E2E_REUSE become the default behavior?

@pablochacin
Copy link
Collaborator Author

pablochacin commented Aug 25, 2023

Wouldn't this cause issues if tests are (accidentally or not) started without E2E_REUSE=1?
If this is the case, shouldn't E2E_REUSE become the default behavior?

The idea is that reusing should not be the default when running each test independently but when running a series of tests to speed up the process.

I think the actual behavior and options are the more sensible choice to cover these two use scenarios.

@pablochacin pablochacin merged commit c2244fc into main Aug 25, 2023
7 checks passed
@pablochacin pablochacin deleted the unify-e2e-configurations branch August 25, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants