-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e: preload httpbin and grpcbin images #343
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to load these images in the corresponding test setup, instead of by default, as I expect the images needed for each test to change over time.
@pablochacin That makes sense. For this to work though, I had to expose a method to load images after the cluster has been created. Otherwise, these images wouldn't get preloaded when running LMK what you think about this approach. |
@@ -39,6 +39,14 @@ func Test_PodDisruptor(t *testing.T) { | |||
_ = cluster.Cleanup() | |||
}) | |||
|
|||
err = cluster.Load( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this code hard to read, I think we could offer a helper function for extracting the images, but this can be in a follow-up PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, it is a bit confusing. I also considered storing those images on an exported constant, and have both fixtures and this code use those constants, but seemed easier to forget than this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! I like this approach of dynamic image loading
Description
This PR adds the
kennethreitz/httpbin
andmoul/grpcbin
to the e2e cluster before tests are run. By doing this, images will be ready when e2e scenarios run, so the time that they take to download won't count against the test timeout, reducing test flakyness.Checklist:
make lint
) and all checks pass.make test
) and all tests pass.make integration-xxx
for affected packages)make e2e-xxx
fordisruptors
, orcluster
related changes)