Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build with xk6 docker image in addition to local xk6 #348

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

roobre
Copy link
Collaborator

@roobre roobre commented Sep 18, 2023

Description

A locally-installed xk6 build might succeed while a build for the same working tree might fail if run from a docker container. I suspect the reason for this might be that the grafana/xk6 container is using go 1.20, while locally we are building with 1.19.

As building with docker is the recommended approach in the xk6 repo, this PR adds a step to the CI to try building k6+disruptor with xk6 in docker.

Related: #330

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant integration test locally (make integration-xxx for affected packages)
  • I have run relevant e2e test locally (make e2e-xxx for disruptors, or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

@roobre roobre force-pushed the ci-xk6-build-docker branch 2 times, most recently from 3b48e9f to 4fe8fdf Compare September 18, 2023 10:02
@roobre roobre changed the title ci: build with xk6 docker image instead of command ci: build with xk6 docker image in addition to local xk6 Sep 18, 2023
@pablochacin
Copy link
Collaborator

pablochacin commented Sep 19, 2023

As building with docker is the recommended approach in the xk6 repo

However, the recommended way to build the disruptor is using the locally installed xk6. If we are changing the way the ci works, we should update the documentation

@roobre
Copy link
Collaborator Author

roobre commented Sep 19, 2023

I think it's fine to keep our current recommended way and docs, unless we have reasons to change them. This PR merely adds another check for an alternative build path we've seen other people use in the wild (probably by recommendation of the xk6 repo).

@roobre roobre merged commit 0611976 into main Sep 21, 2023
8 checks passed
@roobre roobre deleted the ci-xk6-build-docker branch September 21, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants