Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

depsync: Download .mod file from the proxy #352

Merged
merged 1 commit into from
Sep 21, 2023

Conversation

codebien
Copy link
Contributor

Download the go.mod file from the official proxy. In this way we can support any kind of formatted version. e.g. When a specific version pinned by commit is used.

Description

Fixes # (issue)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works.
  • I have run linter locally (make lint) and all checks pass.
  • I have run tests locally (make test) and all tests pass.
  • I have run relevant integration test locally (make integration-xxx for affected packages)
  • I have run relevant e2e test locally (make e2e-xxx for disruptors, or cluster related changes)
  • Any dependent changes have been merged and published in downstream modules

Download the go.mod file from the official proxy. In this way we can
support any kind of formatted version. e.g. When a specific version
pinned by commit is used.
@pablochacin pablochacin requested review from roobre and removed request for roobre September 21, 2023 16:07
@codebien codebien marked this pull request as ready for review September 21, 2023 16:16
@roobre
Copy link
Collaborator

roobre commented Sep 21, 2023

Hey @codebien, thanks for this PR!

If I understand this correctly, this would allow fetching to work when the version specified in go.mod is a pseudoversion e.g. v2.1.4-0.20211119122758-180fcef48034+incompatible. Am I correct?

If so this looks awesome to me so far.

@codebien
Copy link
Contributor Author

codebien commented Sep 21, 2023

@roobre yes, exactly. I would use the k6 master which means go.k6.io/k6 v0.46.1-0.20230921075448-d1c5ee8fb28d but using the GitHub URL didn't work, so I switched to the proxy so it can resolve any version supported by go mod command.

@roobre roobre merged commit e4b1ad9 into grafana:main Sep 21, 2023
7 of 8 checks passed
@codebien codebien deleted the deepsync-@commit branch September 22, 2023 07:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants