Unify fault injection commands #356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
roobre
reviewed
Oct 20, 2023
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
roobre
approved these changes
Oct 23, 2023
pkg/api/convert.go
Outdated
| @@ -17,6 +20,7 @@ import ( | |||
| // string <-- string | |||
| // time.Duration <-- string | |||
| // time.Time <-- string (only in RFC3339 format) | |||
| // IntOrStr <-- string or int64 | |||
There was a problem hiding this comment.
Suggested change
| // IntOrStr <-- string or int64 | |
| // IntOrStr <-- string or int32 |
There was a problem hiding this comment.
This is not a typo. In JS the only int type supported in int64 the API layer will convert to int32 and throws an error if the value overflows. I added a comment to clarify this.
There was a problem hiding this comment.
Does goja support int64s? I though all JS numbers were spec'd as 64b IEEE floats, but I'm not sure how goja does it here.
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
unify-fault-injection-commands
branch
from
cf74ff3
to
b129cd0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the way port mapping is managed in service fault injection to allow reusing the pod injection logic.
Fixes #261 (no longer required)
Checklist:
make lint) and all checks pass.make test) and all tests pass.make integration-xxxfor affected packages)make e2e-xxxfordisruptors, orclusterrelated changes)