Implement CPU stressor #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
resource-stressor
branch
from
8c1ff63
to
0661a8f
Compare
pablochacin
force-pushed
the
resource-stressor
branch
from
79d17ae
to
0661a8f
Compare
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
resource-stressor
branch
2 times, most recently
from
c231177
to
3868609
Compare
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
resource-stressor
branch
from
3868609
to
88bd863
Compare
roobre
reviewed
Nov 15, 2023
pkg/agent/integration_test.go
Outdated
|
|
||
| ctx := context.TODO() | ||
|
|
||
| // start the container with the agent using a fake upstream address because the agent requires it |
There was a problem hiding this comment.
This might be a copy-paste artifact, right? (At least I don't see any address)
cmd/agent/commands/stress.go
Outdated
| return err | ||
| } | ||
|
|
||
| return s.Apply(cmd.Context(), d, duration) |
There was a problem hiding this comment.
In other commands, we use the agent to apply the disruption rather than calling the disruptor directly. Is there a reason to not it like that for this command?
There was a problem hiding this comment.
Good catch. It should follow the same pattern as other commands. I forgot to change this part from the initial PoC implementation.
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
roobre
approved these changes
Nov 16, 2023
|
Hi, |
|
Hi @fslev This experiemntal feature is still not released in the API. We hope to make this available soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements a CPU stress disruptor
Checklist:
make lint) and all checks pass.make test) and all tests pass.make integration-xxxfor affected packages)make e2e-xxxfordisruptors, orclusterrelated changes)