This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
(badly) Fix the extension to work with k6 v0.36.0 #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
approved these changes
Jan 25, 2022
na--
suggested changes
Jan 25, 2022
There was a problem hiding this comment.
Hmm the hack itself is unavoidable, for now, until we have grafana/k6#2293 on the k6 side. And since we plan to have a somewhat different approach to tracing soon (grafana/k6#2128 and others), it should be fine for now.
I think we shouldn't call k6HTTP.New().NewModuleInstance(vu).Exports() on every HTTP request though. Rather, we should call that once per VU and then save it, e.g. in
xk6-distributed-tracing/tracing.go
Lines 63 to 65 in 65e3e99
na--
approved these changes
Jan 25, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.