This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Update the k6 to v0.36.0 #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstoykov
suggested changes
Jan 24, 2022
| @@ -29,49 +31,52 @@ type HttpFunc func(ctx context.Context, url goja.Value, args ...goja.Value) (*k6 | |||
|
|
|||
| func New(vu modules.VU) *TracingClient { | |||
| return &TracingClient{ | |||
| http: &k6HTTP.HTTP{}, | |||
| http: &k6HTTP.Client{}, | |||
There was a problem hiding this comment.
That will just not work as later on you need it's internal fields to be useful see #21 for my at least working fixes ... although arguably the code is a lot worse ;(
There was a problem hiding this comment.
True 😞
I'll check if I can come up with something else, but for now I belive maybe better to merge your PR 👍
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the k6 to the v0.36.0 and use new client