This repository has been archived by the owner on Jan 17, 2024. It is now read-only.
Fix Hex Digit Count in Parent ID for W3C #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Blinkuu
suggested changes
Dec 14, 2022
Blinkuu
approved these changes
Dec 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the W3C traceparent convention from the website (https://www.w3.org/TR/trace-context/#parent-id), the parent ID has to be a 16 byte array, the hex string representation has to contain 16 chars to match the expected length.
Previously the binary was giving parents-id in the form of '7db45e47', when it has to be in the form of '28345e8fd8449de5'
This satisfy the regex used in opentelemetry as well.
(ref: https://github.com/open-telemetry/opentelemetry-go/blob/v1.11.2/propagation/trace_context.go#L44)
The changes add a new variable hex16 that's used only in the w3c propagator, to my knowledge a hex8 should still work in the other two propagations