This repository has been archived by the owner on Sep 17, 2021. It is now read-only.
Add initial k6/x/execution module #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imiric
commented
Jun 21, 2021
imiric
force-pushed
the
feat/initial
branch
2 times, most recently
from
931572e
to
5bec606
Compare
imiric
pushed a commit
to grafana/k6
that referenced
this pull request
Jun 21, 2021
imiric
commented
Jun 22, 2021
| initVU, err := r.NewVU(1, 10, samples) | ||
| require.NoError(t, err) | ||
|
|
||
| execScheduler, err := local.NewExecutionScheduler(r, testutils.NewLogger(t)) |
There was a problem hiding this comment.
Should we simplify these into unit tests, and avoid the ExecutionScheduler and the utils copied to make it work?
There was a problem hiding this comment.
I doubt this repo will long enough for this to matter all that much
imiric
force-pushed
the
feat/initial
branch
3 times, most recently
from
93f2d1d
to
7ffcd9d
Compare
added 3 commits
June 22, 2021 16:45
Some copying and renaming required, but it's not bad.
This was referenced Jun 23, 2021
mstoykov
approved these changes
Jul 1, 2021
codebien
previously requested changes
Aug 25, 2021
Co-authored-by: Ivan <2103732+codebien@users.noreply.github.com>
na--
approved these changes
Aug 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the extracted JS module originally added in grafana/k6#1863. As discussed, we want to make only the core changes required for this module in #1863 and develop the JS API for it separately, so that we can quickly iterate on it from community feedback.
I tested this with
xk6 build 0314986c --with github.com/k6io/xk6-execution=.and it works fine, but we should translate the tests for it to be run in this repo somehow, probably in CI. Suggestions welcome.