This repository has been archived by the owner on May 21, 2024. It is now read-only.
Update the k6 dependency which updates also GRPC dependencies #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
approved these changes
May 18, 2023
codebien
reviewed
May 18, 2023
Comment on lines
+266
to
+272
| // a small hack to make sure we are parsing the right file | ||
| // otherwise the parser will try to parse "google/protobuf/descriptor.proto" | ||
| // with exactly the same name as the one we are trying to parse for testing | ||
| if filename != path { | ||
| return nil, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Same question as grafana/k6#3075 (comment)
It isn't clear why this is happening and if we should improve here in the future.
There was a problem hiding this comment.
I answered there, but answering here also.
As the comment stays:
// the parser will try to parse "google/protobuf/descriptor.proto"
Generally, it's a result of the library update, but on the other hand, it's a clear signal that the test was poorly designed and is sensitive to that kind of update.
Hopefully, we can improve that (and many other tests).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Updates the k6 dependency, which is also updating GRPC dependencies.
Based on the: grafana/k6#3075
Why?
Make dependencies updated.