This repository has been archived by the owner on May 21, 2024. It is now read-only.
Parameterisation of the Stream #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olegbespalov
force-pushed
the
feat/grpc-streaming
branch
9 times, most recently
from
976a2f0
to
de04ac4
Compare
olegbespalov
force-pushed
the
feat/grpc-params
branch
from
f385700
to
93053cb
Compare
olegbespalov
force-pushed
the
feat/grpc-params
branch
from
93053cb
to
5476adb
Compare
olegbespalov
force-pushed
the
feat/grpc-params
branch
from
5ef09d6
to
cd49899
Compare
codebien
suggested changes
May 10, 2023
|
Hey @codebien I've applied the changes based on your comments, please re-check and let me know what do you think |
mstoykov
approved these changes
May 17, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Abstraction of the GRPC's calls (invoke & streams) parameterization. And we are applying it to the Stream's constructor.
Why?
We need that for the API.
Closes: #8