fix for registering nested message types

[thiagodpf]

@mstoykov Related to this issue.

[CLAassistant]

All committers have signed the CLA.

[olegbespalov]

Hi @thiagodpf !

First of all, I'd like to thank you for raising the issue and working on a fix 🙇 Great job!

Regarding the PR, it looks good 👍

However, the one possible improvement could be implementing the stack here instead of using the github.com/golang-collections/collections package (the go implementation is pretty straightforward). The rationale is to reduce the number of libraries we import, improving maintainability.

How does that sound?

[thiagodpf]

Hi @olegbespalov !!
I think it's great! I will do this!
Do you see any problems if I bring in the stack implementation from the golang-collections library as-is?
Another point is, is there a file/directory where the stack is better placed or should I include it in the client.go file itself?

[olegbespalov]

Looks good to me! 🚀

Thank you for your contribution! 🙇

[mstoykov]

Thanks for the work on this 🙇

[olegbespalov]

@thiagodpf just a tiny update on the next steps 👍

We're going to pack some more changes into the xk6-grpc "release" and once it is done, bump the new version in the primary k6's repo. Once that is done, the k6's experimental module will get the fixes.

In parallel, we're going to backport the changes to the legacy k6/net/grpc module. For sure if you want you could do the last part also by yourself, but according to our freshly posted contribution guidelines we don't expect this.

Thanks again! 🚀

[thiagodpf]

@olegbespalov thanks for accepting my PR!
So in a few hours I will backport the PR into the legacy module.
Thanks for all the help!

[thiagodpf]

Done! ✌️😃
grafana/k6#3178

Again, thanks for the support and help!