This is a port of the PR changes found here: #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
olegbespalov
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Hey @chrismoran-mica !
Let's port the latest changes from the grafana/k6#3159, and we can merge it 👍
Thanks for your contribution! 🙇
|
I’m on the road but I’ll get this sorted sometime this weekend. On Jul 13, 2023, at 3:41 AM, Oleg Bespalov ***@***.***> wrote:
@olegbespalov requested changes on this pull request.
Hey @chrismoran-mica !
Let's take the latest changes from the grafana/k6#3159, and we can merge it 👍
Thanks for your contribution! 🙇
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Note: The bad auth/bad certificate tests appear to be very inconsistent. In grafana/k6 I had to remove the timeout for them to pass in CI. Removing the timeout in grafana/xk6-grpc caused the tests to fail locally. This may need to be investigated or a bug raised to determine if k6 is not raising grpc connection errors on bad authentication until context deadline.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
grafana/k6#3159
Let me know if anything else is needed to facilitate this change.
Closes: #27