This repository has been archived by the owner on May 21, 2024. It is now read-only.
Integration Tests #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
olegbespalov
force-pushed
the
feat/tests
branch
2 times, most recently
from
bf43b14
to
b56a05b
Compare
mstoykov
approved these changes
Apr 5, 2023
This PR brings the "integration" tests into the extension. It extracts the logic of the demo service that is also a good candidate for the testing and uses the exact proto definition and the scripts we employ in the examples. The reason is that "integration" tests are usually hard to read, and it's great to have the possibility to run the exact same case, just standalone. Apart from that, they test output.
mstoykov
approved these changes
Apr 5, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR brings the "integration" tests into the extension. It extracts the logic of the demo service that is also a good candidate for the testing and uses the exact proto definition and the scripts we employ in the examples.
The reason is that "integration" tests are usually hard to read, and it's great to have the possibility to run exact same case, just standalone. Apart from that, they test output.
Why?
The tests are essential.