GRPC reflection v1 #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This introduces support of the reflaction v1 (and presume support of the reflection v1alpa)
olegbespalov
requested review from
mstoykov and
codebien
and removed request for
a team
codebien
requested changes
Sep 5, 2023
codebien
approved these changes
Sep 5, 2023
|
Anyway, I've added the test case where service implements only |
codebien
approved these changes
Sep 5, 2023
mstoykov
approved these changes
Sep 7, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
These changes bring support to the GRPC reflection v1 (while keeping the support of the v1alpha)
It also refactors the logic of collecting file descriptors by simplifying it.
Why?
Resolves: #14
Resolves: #32 (if this PR merged we don't need to port)