Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename kill for Delete #18

Closed
ppcano opened this issue Oct 21, 2021 · 1 comment
Closed

Rename kill for Delete #18

ppcano opened this issue Oct 21, 2021 · 1 comment
Assignees
@javaducky

Comments

@ppcano
Copy link
Contributor

ppcano commented Oct 21, 2021

This library wraps the k8s.io/client-go to expose the APIs in a k6 extension.

On k8s.io/client-go, the method name to delete a resource is Delete instead of Kill. I think we should align with the method names of the original library
@javaducky javaducky self-assigned this Mar 3, 2022
javaducky added a commit that referenced this issue Mar 3, 2022
@javaducky
Addresses issue #18 to migrate API usage from "kill" to "delete"
75a144d 
Deprecates the "kill" method.
@javaducky
Copy link
Contributor

Added the Delete methods to objects and marked the old Kill methods as deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@javaducky javaducky

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ppcano @javaducky