Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

building with make fails because local module is not used #27

Closed
pablochacin opened this issue Apr 9, 2022 · 1 comment
Closed

building with make fails because local module is not used #27

pablochacin opened this issue Apr 9, 2022 · 1 comment
Assignees

Comments

@pablochacin
Copy link
Contributor

After forking the repository for adding a new package nodes, the make command failed because it was still referencing the xk6-kubernetes package from the github repository:

github.com/grafana/xk6-kubernetes/pkg/nodes: module github.com/grafana/xk6-kubernetes@latest found (v0.0.0-20220330204656-f40616db6d32), but does not contain package github.com/grafana/xk6-kubernetes/pkg/nodes

Removing the --with option in the k6 build command in the Makefile solves the issue.

--- a/Makefile
+++ b/Makefile
@@ -19,7 +19,7 @@ clean:
 ## build: Builds a custom 'k6' with the local extension. 
 build:
        go install go.k6.io/xk6/cmd/xk6@latest
-       xk6 build --with github.com/grafana/xk6-output-prometheus-remote=.
+       xk6 build

This behavior is unexpected as xk6 should add the current module to the list of replaced modules.

@ppcano
Copy link
Contributor

ppcano commented Apr 18, 2022

cc @javaducky

javaducky added a commit that referenced this issue Apr 22, 2022
Fixes #27 by correcting a "copy/paste error" in the Makefile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants