Add Pod methods #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simskij
suggested changes
Apr 23, 2021
|
@simskij comments are handled, Pod Kill and Pod Get added. Review again please |
simskij
suggested changes
Apr 27, 2021
README.md
Outdated
|
|
||
| # xk6-kubernetes | ||
| A k6 extension for using of K8s in testing. Built for [k6](https://github.com/loadimpact/k6) using [xk6](https://github.com/k6io/xk6). |
There was a problem hiding this comment.
Suggested change
| A k6 extension for using of K8s in testing. Built for [k6](https://github.com/loadimpact/k6) using [xk6](https://github.com/k6io/xk6). | |
| A k6 extension for interacting with Kubernetes clusters while testing. Built for [k6](https://github.com/loadimpact/k6) using [xk6](https://github.com/k6io/xk6). |
pods.go
Outdated
| ) | ||
|
|
||
| type PodsNamespace struct { | ||
| Client *kubernetes.Clientset |
There was a problem hiding this comment.
This should probably be private, right?
examples/kill-pod.js
Outdated
| let podsList = getPodNames(nameSpace, kubernetes) | ||
| const podName = Object.keys(podsList)[0] | ||
| kubernetes.pods.kill(podName, nameSpace) | ||
| // TODO: for some reason we can't feel terminating status |
There was a problem hiding this comment.
This is determined by checking pod.object_meta.deletion_timestamp. If it's not null, it has received a termination instruction. Maybe kubernetes.pods.isTerminating(pod) could return a bool based on this condition, as state changes won't be pushed to the js object you already have.
|
@simskij comments handled review again, please. The rest functionality will be handled in upcoming PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getPodsmethod