Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating extension to utilize the latest module API #32

Merged
merged 2 commits into from
Apr 21, 2022

Conversation

javaducky
Copy link
Contributor

v0.38.0 will be removing deprecated module APIs. This update will be required going forward.

Fixes issue #31.

Copy link
Contributor

@mstoykov mstoykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - some nitpicks

kubernetes.go Outdated Show resolved Hide resolved
kubernetes.go Outdated Show resolved Hide resolved
Copy link

@olegbespalov olegbespalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

Removed the `Version` as it is thus far unused and we need to determine an overarching versioning strategy for extensions anyway.
@javaducky javaducky merged commit 571b3b6 into main Apr 21, 2022
@javaducky javaducky deleted the feature/module-refresh branch April 22, 2022 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants