Add ephemeral container to a running pod #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
changed the title
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
javaducky
suggested changes
Apr 22, 2022
| @@ -17,12 +20,27 @@ func New(client *kubernetes.Clientset, metaOptions metav1.ListOptions, ctx conte | |||
| } | |||
| } | |||
|
|
|||
| type ContainerOptions struct { | |||
There was a problem hiding this comment.
Please include Go documentation on any public types and methods.
There was a problem hiding this comment.
Hi @javaducky I added some comments, but I'm not sure what conventions is the project following in this regard. Could you please point me to some examples I can use as a reference?
There was a problem hiding this comment.
There was a problem hiding this comment.
Added documentation.
|
Confirmed create and add with Kube v1.22.7 ( |
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
pablochacin
force-pushed
the
add-ephemeral-container
branch
from
fb0c135
to
611489a
Compare
javaducky
approved these changes
Apr 25, 2022
|
LGTM! Thank you @pablochacin . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to Pods for creating an ephemeral container in a running pod.
Also added a function for creating a pod to facilitate testing.
Note: tested with K8s cluster 1.23.x. Previous versions may not work or may need enabling ephemeral containers feature gate
closes #30