Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto cleanup jobs #49

Merged
merged 3 commits into from
May 24, 2022
Merged

Auto cleanup jobs #49

merged 3 commits into from
May 24, 2022

Conversation

pablochacin
Copy link
Contributor

@pablochacin pablochacin commented May 22, 2022

Add option to Create job for automatically delete job on completion and delete in cascade pods when the job is deleted.

Note to reviewers: the default behavior of job Delete has changed and pods are always deleted when the Job is deleted. This option was chose over adding options for controlling this behavior that will introduces a change in the API (mandatory additional parameter: jobs.Delete(namespace, name, cascade))

closes: #47

Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
Signed-off-by: Pablo Chacin <pablochacin@gmail.com>
@javaducky javaducky self-requested a review May 24, 2022 17:07
Copy link
Contributor

@javaducky javaducky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@javaducky javaducky merged commit 222e445 into grafana:main May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add options for job cleanup
2 participants